GH-49400: [Ruby] Add Arrow::FixedSizeList#values and #raw_records#49401
Merged
Conversation
|
|
github-actions
Bot
added
Component: Ruby
awaiting committer review
Member
Author
|
+1 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 879bbb3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them. |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Apr 6, 2026
…cords` (apache#49401) ### Rationale for this change They are optimized C++ values -> Ruby values converters. ### What changes are included in this PR? * Add support for `arrow::FixedSizeListArray` in `#values` and `#raw_records` implementation in C++ * Add tests for `Arrow::FixedSizeList#values` and `#raw_values` * Add tests for `Arrow::LargeList#values` and `#raw_values` because they are missing * This is not so related to `Arrow::FixedSizeList#values` and `#raw_values`. Sorry. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49400 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
They are optimized C++ values -> Ruby values converters.
What changes are included in this PR?
arrow::FixedSizeListArrayin#valuesand#raw_recordsimplementation in C++Arrow::FixedSizeList#valuesand#raw_valuesArrow::LargeList#valuesand#raw_valuesbecause they are missingArrow::FixedSizeList#valuesand#raw_values. Sorry.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
Arrow::FixedSizeList#valuesand#raw_records#49400